search

Sowa1980 / hunting_and_fishing_preset

0 stars 0 forks source link

Icon errors #1

Open Klumbumbus opened 2 years ago

Klumbumbus commented 2 years ago

There are icon errors, could you please fix them? (Empty icon paths are invalid.)

00971.991 W: [RELATION, CLOSEDWAY, MULTIPOLYGON] spawning area: Could not get presets icon
00971.981 W: [RELATION, CLOSEDWAY, MULTIPOLYGON] hunting farm: Could not get presets icon
00971.975 W:  hunting_and_fishing: Could not get presets icon 
00971.986 W: [RELATION, CLOSEDWAY, MULTIPOLYGON] Зимовальная яма: Could not get presets icon
00971.994 W: [RELATION, CLOSEDWAY, MULTIPOLYGON] spawning area: Could not get presets icon

https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/lastCompletedBuild/jdk=JDK8/testReport/org.openstreetmap.josm.gui.preferences.map/TaggingPresetPreferenceTestIT/hunting_and_fishing___https___github_com_Sowa1980_hunting_and_fishing_preset_blob_master_hunting_and_fishing_preset_zip/

tsmock commented 2 years ago

@Sowa1980 : I have removed this from the preset list in order to conform with the stated policy,

Unmaintained and invalid presets causing errors in JOSM unit tests. Presets can be restored only after their errors are fixed upstream:

See https://josm.openstreetmap.de/wiki/PresetsSource?action=diff&version=158 . Feel free to revert that change when you have fixed your preset.

Sowa1980 commented 2 years ago

Исправлено, удалены пустые пути к Icon.

Klumbumbus commented 2 years ago

It's not fixed. Neither the xml nor the zip was changed.

https://josm.openstreetmap.de/wiki/PresetsSource?action=diff&version=161

Sowa1980 commented 2 years ago

version=0.3_2022-05-03 delete Icon