search

SoySauceLab / CollectionKit

Reimagining UICollectionView
MIT License
4.4k stars 259 forks source link

Class based size source #107

Closed lkzhao closed 5 years ago

lkzhao commented 5 years ago

https://github.com/SoySauceLab/CollectionKit/issues/98

lkzhao commented 5 years ago

This PR not only introduce class-based size source but also some convenience inits for creating BasicProvider. We can now provide Array as DataSource, viewUpdater function as viewSource, and also provide the old sizeSource function as SizeSource.

codecov-io commented 5 years ago

Codecov Report

Merging #107 into master will decrease coverage by 3.81%. The diff coverage is 17.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage    56.1%   52.28%   -3.82%     
==========================================
  Files          35       37       +2     
  Lines         991     1094     +103     
==========================================
+ Hits          556      572      +16     
- Misses        435      522      +87
Impacted Files Coverage Δ
Sources/Provider/ComposedHeaderProvider.swift 0% <0%> (ø) :arrow_up:
.../Provider/ComposedHeaderProvider+Convenience.swift 0% <0%> (ø)
Sources/ViewSource/ClosureViewSource.swift 76.92% <100%> (ø) :arrow_up:
Sources/Provider/BasicProvider.swift 77.77% <100%> (ø) :arrow_up:
Sources/Provider/BasicProvider+Convenience.swift 20.77% <20.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b0571d...8942bd3. Read the comment docs.