Closed lkzhao closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
master@b704b3b
). Click here to learn what that means. The diff coverage is23.25%
.
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
Coverage ? 70.16%
=========================================
Files ? 41
Lines ? 1123
Branches ? 0
=========================================
Hits ? 788
Misses ? 335
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
Sources/Protocol/Provider.swift | 100% <ø> (ø) |
|
Sources/DataSource/ClosureDataSource.swift | 0% <0%> (ø) |
|
Sources/SizeSource/UIImageSizeSource.swift | 0% <0%> (ø) |
|
Sources/SizeSource/SimpleViewSizeSource.swift | 0% <0%> (ø) |
|
Sources/ViewSource/ViewSource.swift | 50% <0%> (ø) |
|
Sources/SizeSource/ClosureSizeSource.swift | 100% <100%> (ø) |
|
Sources/Provider/BasicProvider.swift | 77.77% <100%> (ø) |
|
Sources/DataSource/ArrayDataSource.swift | 100% <100%> (ø) |
|
Sources/Provider/ComposedHeaderProvider.swift | 78.65% <100%> (ø) |
|
Sources/SizeSource/SizeSource.swift | 33.33% <33.33%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b704b3b...3703e43. Read the comment docs.
Now that class-based size source is merged. we can now simplify SimpleViewProvider. In this PR
SimpleViewSizeSource
class that is responsible for taking care of view sizing.SimpleViewProvider
a subclass BasicProvider again.