search

Soyle-Productions / soyle-stories

An application to help writers keep track of all aspects of their stories without getting in the way of the creative process and offering deep insights into potential plot holes.
Apache License 2.0
13 stars 0 forks source link

Changing Perspective Character to Minor Character Creates Error #87

Closed ryanreso1993 closed 3 years ago

ryanreso1993 commented 3 years ago

Create two characters: Bob and Alice Create a character arc for Bob Open the Character Conflict tool for Bob's arc Add Alice as an opponent to Bob Change the perspective to Bob

What I expect to happen: Then the other character becomes a Major Character

What actually happens: Then the other character becomes a Major Character, but the program displays this error:

Error message:

com.soyle.stories.domain.theme.CharacterIsNotMajorCharacterInTheme at com.soyle.stories.usecase.theme.examineCentralConflictOfTheme.ExamineCentralConflictOfThemeUseCase.getMajorCharacter(ExamineCentralConflictOfThemeUseCase.kt:91) at com.soyle.stories.usecase.theme.examineCentralConflictOfTheme.ExamineCentralConflictOfThemeUseCase.getExaminedCharacterChange(ExamineCentralConflictOfThemeUseCase.kt:38) at com.soyle.stories.usecase.theme.examineCentralConflictOfTheme.ExamineCentralConflictOfThemeUseCase.invoke(ExamineCentralConflictOfThemeUseCase.kt:27) at com.soyle.stories.theme.characterConflict.CharacterConflictController$getValidState$1.invokeSuspend(CharacterConflictController.kt:51) at com.soyle.stories.theme.characterConflict.CharacterConflictController$getValidState$1.invoke(CharacterConflictController.kt) at com.soyle.stories.theme.characterConflict.CharacterConflictController$getValidState$1.invoke(CharacterConflictController.kt) at com.soyle.stories.common.AsyncThreadTransformer$async$1$1.invokeSuspend(ThreadTransformerImpl.kt:12) at com.soyle.stories.common.AsyncThreadTransformer$async$1$1.invoke(ThreadTransformerImpl.kt) at com.soyle.stories.common.AsyncThreadTransformer$async$1$1.invoke(ThreadTransformerImpl.kt) at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturnIgnoreTimeout(Undispatched.kt:102) at kotlinx.coroutines.TimeoutKt.setupTimeout(Timeout.kt:148) at kotlinx.coroutines.TimeoutKt.withTimeout(Timeout.kt:44) at com.soyle.stories.common.AsyncThreadTransformer$async$1.invokeSuspend(ThreadTransformerImpl.kt:11) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

b-camphart commented 3 years ago

@ryanreso1993 please verify with new release

ryanreso1993 commented 3 years ago

@ryanreso1993 please verify with new release

Cannot reproduce, unable to locate Character Conflict Tool from Character Arc

b-camphart commented 3 years ago

Take a look in the theme list tool

ryanreso1993 commented 3 years ago

Still running into error. Kindly advise.

Can: Create two characters Bob and Alice Create a theme Right click the theme and open Examine Central Conflict

Cannot: Add Alice as an opponent to Bob Change the perspective to Bob

b-camphart commented 3 years ago

Right now, the only perspective characters you can select are characters in the theme. Should the menu look like this instead:

Major Characters Minor Characters Other Characters in Project Create New Character

Would that make sense?

ryanreso1993 commented 3 years ago

Ok yes I think that’s clearer and points the user better.

On Tue, Aug 3, 2021 at 5:32 PM Brendan Campbell-Hartzell < @.***> wrote:

Assigned #87 https://github.com/Soyle-Productions/soyle-stories-desktop/issues/87 to @ryanreso1993 https://github.com/ryanreso1993.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/Soyle-Productions/soyle-stories-desktop/issues/87#event-5107660499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOSVMESZ4HKH6THKKLSW5QTT3B4CVANCNFSM45K4VYCQ .