search

SoylentNews / rehash

Forked from Slashcode, rehash is the codebase that powers SoylentNews.org, powered by mod_perl 2
http://soylentnews.org
GNU General Public License v2.0
57 stars 26 forks source link

'a' tags matched differently in journal and comments #460

Open hendrikboom3 opened 5 years ago

hendrikboom3 commented 5 years ago

In the starting paragraph starting 'the second video' in the post 'Retail Therapy' on December 29, 2018 in the journal https://soylentnews.org/~NPC-131072/journal/ that paragraph consists of two links.

But on its comments page, https://soylentnews.org/comments.pl?sid=29372 only a small part of that paragraph is a link.

And the link in the previous paragraph seems not to be properly terminated by an before the end of its containing paragraph. We end up with links inside a link.

While this may be valid HTML, it's different between the journal entry and the comments page.

I suspect the discrepancy is not intentional.

-- hendrik

marty-b commented 5 years ago

On 12/29/2018 7:44 PM, hendrikboom3 wrote:

In the starting paragraph starting 'the second video' in the post 'Retail Therapy' on December 29, 2018 in the journal https://soylentnews.org/~NPC-131072/journal/ https://soylentnews.org/%7ENPC-131072/journal/ that paragraph consists of two links.

But on its comments page, https://soylentnews.org/comments.pl?sid=29372 only a small part of that paragraph is a link.

And the link in the previous paragraph seems not to be properly terminated by an before the end of its containing paragraph. We end up with links inside a link.

While this may be valid HTML, it's different between the journal entry and the comments page.

I suspect the discrepancy is not intentional.

-- hendrik

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SoylentNews/rehash/issues/460, or mute the thread https://github.com/notifications/unsubscribe-auth/AGfiDT67MX2jWhbaHhZ5tzUjLGM1l_xJks5u-AxmgaJpZM4Zkw7c.

Hi! Thanks for reporting this.  I looked into the postings and it appears the problem arises from also having this attribute in your anchor tags:     rel="nofollow" I've seen something similar happen when editing stories for the site.  Please try editing you journal entry and remove all places there that attribute appears and I expect all should then be okay.

As to why that attribute does get stripped when producing the story text when viewing a comment, but not otherwise... that's another matter and I have no answer for that.  In the meantime, please try removing that attribute and letting us know if that succeeds.  If so, then we at least have a viable workaround. --martyb

hendrikboom3 commented 5 years ago

It's not my post or my journal -- so I can't remove the attribute.