So this is mostly to fix titles in subs and stories getting mangled because the encodings were not correct. They should have always been filtered on strip_attribute as this encodes both < and > and double quotes. Without double quotes being encoded in titles the rest of the title gets truncated in the input box (html ends the attribute at the "). Upon a update or preview the title is reserved with the broken title. By encoding < and > we do not have live html code getting into the title. To keep them clean I have added strip_attribute to many places in the code for subj and title to make sure that any bad data passed here is eventually cleaned (save and update routines now strip_attribute on the title before saving so it is not saved back into the db). I have also fixed the issue where the encode_html_amp was re-encoding & even inside a entity by using the encode_html_amp_ifnotent regex instead.
Also fixed are spacing issues in the submissions list that gewg_ mentioned and an issue with AC's by line linking to the nonexistent AC info page.
All of these issues were not listed here but rather mentioned in IRC or on the site.
Note to TheMichtyBuzzard: there are four lines that need merged into Data.pm in pull #354 so we can easily merge it later. I would like to get this out as a point release this weekend.
So this is mostly to fix titles in subs and stories getting mangled because the encodings were not correct. They should have always been filtered on strip_attribute as this encodes both < and > and double quotes. Without double quotes being encoded in titles the rest of the title gets truncated in the input box (html ends the attribute at the "). Upon a update or preview the title is reserved with the broken title. By encoding < and > we do not have live html code getting into the title. To keep them clean I have added strip_attribute to many places in the code for subj and title to make sure that any bad data passed here is eventually cleaned (save and update routines now strip_attribute on the title before saving so it is not saved back into the db). I have also fixed the issue where the encode_html_amp was re-encoding & even inside a entity by using the encode_html_amp_ifnotent regex instead.
Also fixed are spacing issues in the submissions list that gewg_ mentioned and an issue with AC's by line linking to the nonexistent AC info page.
All of these issues were not listed here but rather mentioned in IRC or on the site.
Note to TheMichtyBuzzard: there are four lines that need merged into Data.pm in pull #354 so we can easily merge it later. I would like to get this out as a point release this weekend.