SoylentNews / slashcode

The slashcode repository for SoylentNews. The initial code base was uploaded as it appeared on Sourceforge as of the last commit in September 2009
http://soylentnews.org
GNU General Public License v2.0
44 stars 22 forks source link

Story Preview label padding-top issue #440

Closed soytakyon closed 9 years ago

soytakyon commented 9 years ago

Google Chrome, Windows mrcoolbp can confirm this issue

The 1em of padding-top given to label elements seems to be obscuring other elements.

For example it is difficult to click on the input element that holds the publishing timestamp, because the padding from the "Link Story to Existing Poll" label is obscuring it. You can't click on part of that link because the padding from "Attach File" is obscuring that.

Getting rid of "padding: 1em 0 0 0;" added to all label elements solved the issue:

admin.pl base.css?slashcode_15_03 block starting on line 868

label { display: block; font-weight: bold; padding: 1em 0 0 0; }

label { display: block; font-weight: bold; /* padding: 1em 0 0 0; */ }

paulej72 commented 9 years ago

Wow, the code on the story edit page is just crap. I never realized how bad some of this was. I think the issue is to fix the broken page layout first then I’ll see if a css fix is need. Was this issue happening elsewhere?

From: soytakyon [mailto:notifications@github.com] Sent: Sunday, April 12, 2015 8:20 PM To: SoylentNews/slashcode Subject: [slashcode] Story Preview label padding-top issue (#440)

Google Chrome, Windows mrcoolbp can confirm this issue

The 1em of padding-top given to label elements seems to be obscuring other elements.

For example it is difficult to click on the input element that holds the publishing timestamp, because the padding from the "Link Story to Existing Poll" label is obscuring it. You can't click on part of that link because the padding from "Attach File" is obscuring that.

Getting rid of "padding: 1em 0 0 0;" added to all label elements solved the issue:

admin.pl base.css?slashcode_15_03 block starting on line 868

label { display: block; font-weight: bold; padding: 1em 0 0 0; }

label { display: block; font-weight: bold; /* padding: 1em 0 0 0; */ }

— Reply to this email directly or view it on GitHubhttps://github.com/SoylentNews/slashcode/issues/440.

soytakyon commented 9 years ago

A label will make it impossible to click anything 1em above it, at least on Chrome. It's why I mentioned the links, they are inside label elements that cover up the links above them and the input type="text" box.

paulej72 commented 9 years ago

Fixed in #443