SpEcHiDe / UploadGram

https://pypi.org/project/uploadgram/
GNU Affero General Public License v3.0
102 stars 24 forks source link

Bug - Some audio files are wrongly tagged #5

Open tissole opened 3 years ago

tissole commented 3 years ago

I'm on Windows 10 running uploadgram 0.1.7

I uploaded an audiobook and the script tags the files incorrectly. The first file gets tags from the second file, the second from the third, etc. The same thing happens when using the other script telegram-upload. Since both are using Hachoir I suspect that may be a bug in that library.

The tags appear correctly when the files are played in VLC and PotPlayer. I also used a bot for tagging and the tags are shown properly (bot is using Mutagen library).

If the issue is in the Hachoir and can not be fixed, please consider adding support for the Mutagen library for audio tagging.

SpEcHiDe commented 3 years ago

can you share an example (preferably sent as zip) file?

tissole commented 3 years ago

Sure

SpEcHiDe commented 3 years ago

I just downloaded this and uploaded, I found the files like this, https://telegra.ph/file/1c854853be6c6e61564b1.jpg https://telegra.ph/file/ea34b155e4703ad55e89a.jpg

How should the audio tags be displayed? 😅 I don't understand what the issue is.

can you send a screenshot of how the audio files are expected to look like?

tissole commented 3 years ago

The filenames on my PC

files And after uplod uploaded

The captions are set correctly after the filenames, but the filenames are wrong. After the upload, the first file is renamed "Lecture 01. The European Background" which is actually the name of the second file before the upload. The second file is renamed "Lecture 02. Natives And Newcomers" which is the name of the third file. The third file is renamed Lecture 03. The Puritans which is actually the name of the fourth file and so on...

This is how they are tagged by a bot who uses Mutagen bot

tissole commented 3 years ago

Unable to re-produce label...You actually reproduced it pretty well. Look again at your screenshots. https://telegra.ph/file/1c854853be6c6e61564b1.jpg https://telegra.ph/file/ea34b155e4703ad55e89a.jpg The first file is named "Lecture 01. The European Background" which is not correct, this is the title of the second file. Don't get distracted by the captions :)

SpEcHiDe commented 3 years ago

Had not understood, 🤧😂

tissole commented 3 years ago

I think you got it right this time. This is the bot I mentioned before, based on pyrogram, maybe it helps.