Composite/augmented basis issues

SpM-lab / SparseIR.jl

On-the-fly computation of IR basis functions

https://spm-lab.github.io/SparseIR.jl

MIT License

20 stars 0 forks source link

Closed mwallerb closed 2 years ago

mwallerb commented 2 years ago

The composite/augmented basis things are in a pretty sorry state right now.

Problems:

there is essentially no documentation on how and why to use this
the interface is not type-stable at all, it stores a bunch of Vector{Any} and Union{...} instead of doing this properly
the sampling points are incorrect! composite basis does not actually augment the sampling points in any way, which completely wrecks any fitting procedure.

shinaoka commented 2 years ago

This is too Pythonic. CompositeBasis should be a parametric type at least. But, how about u and v?

SamuelBadr commented 2 years ago