search

SpaceApi / schema

SpaceAPI JSON schema files.
24 stars 14 forks source link

Add areas to location #107

Closed dbrgn closed 2 months ago

dbrgn commented 2 months ago

This key can be used to specify a list of areas that make up your physical location. Each area has a required size (in square meters), and an optional name and description.

Replaces #71. (See discussion in that MR for context.)

dbrgn commented 2 months ago

@SpaceApi/core if I understood you correctly during today's meeting, this was the proposal that we converged on. Do you agree with that?

(The old PR was still against schema v14-draft, btw 😂)

rnestler commented 2 months ago

@dbrgn Whats holding the merge back?

dbrgn commented 2 months ago

@dbrgn Whats holding the merge back?

4 hours ago, it was the missing second review 😂 Once you added your review, you could have hit the "merge" button.

rnestler commented 2 months ago

4 hours ago, it was the missing second review 😂 Once you added your review, you could have hit the "merge" button.

Ah I think we agreed that 1 review is enough if the change comes from a core member anyways.