dbrgn
commented
2 months ago Never mind, I temporarily disabled the required approvals, since we already got 2 for this PR.
Closed dbrgn closed 2 months ago
dbrgn
commented
2 months ago Never mind, I temporarily disabled the required approvals, since we already got 2 for this PR.
UGH, reviews are auto-dismissed after force pushes, even when just rebasing.
I unchecked "Dismiss stale pull request approvals when new commits are pushed" in the settings and reduced the number of required approvals to 1 (we'll still use common sense before clicking merge).
@s3lph would you care to re-approve after my rebase?