search

SpaceApi / schema

SpaceAPI JSON schema files.
24 stars 14 forks source link

refactoring to use refs, unifies sensors #22

Closed gidsi closed 4 years ago

gidsi commented 6 years ago

Please note that this also removes the requirement to have a location from any sensor.

Also makes use of draft-04 attribute "allOf"

rnestler commented 6 years ago

Oh this one looks nice and removes quite a lot of redundancy! But it will take some time to review it carefully, since it touches a lot of stuff.

gidsi commented 6 years ago

Yeah, i expected that, and im not a 100% sure if i got everything right. We should write some tests or a "default" implementation where we can check against :)

Btw, i also simplified the wind sensor, not sure why but it had another attribute key inside his own root part with the different readings inside. Didn't make sense to me.

dbrgn commented 6 years ago

We're in the good position that we can write tests against all current implementations :)

(That's actually one of the cases where a cache is quite useful for fast testing. Some of the endpoints are very slow.)

gidsi commented 4 years ago

Got stale, will redo later.