search

SpaceApi / website

The spaceapi.io website.
https://spaceapi.io/
16 stars 28 forks source link

Add Member Matters to the provide an endpoint page #132

Closed jabelone closed 6 months ago

jabelone commented 7 months ago

An example instance can be seen on my makerspace's portal here for reference: https://portal.brisbanemaker.space/api/spacedirectory/

rnestler commented 7 months ago

@jabelone Can you rebase your branch? We had problems with the CI config, which should be fixed now.

dbrgn commented 7 months ago

Regarding the .DS_STORE commit, I'm not a fan of that, since this is something that should typically be added to your user- or system-wide gitignore instead because it is specific to your operating system. You can find the location of your systemwide gitignore with git config --get core.excludesfile. I'd be fine with adding it to our .gitignore though since it doesn't hurt either.

Additionally, the filename is actually wrong, it should be .DS_Store. All-uppercase only works because macOS has a case-insensitive file system by default, but it won't match the file if the file system is case sensitive.

It would be great if you could either update or remove that commit.

jabelone commented 6 months ago

@rnestler and @dbrgn I have updated and rebased. Thanks!