SpaceCat97 / SpaceCats-Wikis

Other
2 stars 0 forks source link

CVT: Unable to Set Certain Potion Effects in Trade Config File #23

Closed warrentode closed 1 month ago

warrentode commented 3 months ago

Version: Minecraft 1.19.2 in Forge (customvillagertrades-forge-19.24.0)

The following lines of code produce an uncraftable potion with an NBT for color that wasn't put in the config file:

{ "additionalRequest": { "itemKey": "minecraft:potion", "amount": 1, "priceModifier": 0, "advancedNBTData": "{Potion:\"minecraft:awkward\"}" } }

{ "additionalRequest": { "itemKey": "minecraft:potion", "amount": 1, "priceModifier": 0, "advancedNBTData": "{Potion:\"minecraft:thick\"}" } }

{ "additionalRequest": { "itemKey": "minecraft:potion", "amount": 1, "priceModifier": 0, "advancedNBTData": "{Potion:\"minecraft:water\"}" } }

And the following lines of code only produce the effect key is invalid error, thus failing to load the trade entirely:

{ "additionalRequest": { "itemKey": "minecraft:potion", "amount": 1, "priceModifier": 0, "effects": [ { "effectKey": "minecraft:awkward", "duration": 1200, "level": 0, "isVisible": true, "potionKey": "minecraft:awkward" } ] } }

{ "additionalRequest": { "itemKey": "minecraft:potion", "amount": 1, "priceModifier": 0, "effects": [ { "effectKey": "minecraft:thick", "duration": 1200, "level": 0, "isVisible": true, "potionKey": "minecraft:thick" } ] } }

{ "additionalRequest": { "itemKey": "minecraft:potion", "amount": 1, "priceModifier": 0, "effects": [ { "effectKey": "minecraft:water", "duration": 1200, "level": 0, "isVisible": true, "potionKey": "minecraft:water" } ] } }

SpaceCat97 commented 3 months ago

This will be fixed in the next update.

A few notes:

The best way to do this would be to use the advancedNBTData as you've done in your example, and do not define any effects.

warrentode commented 3 months ago

The best way to do this would be to use the advancedNBTData as you've done in your example, and do not define any effects.

Will doing it this way get me the water?

SpaceCat97 commented 2 months ago

Yes, when the next update is released.