search

SpaceCat97 / SpaceCats-Wikis

Other
2 stars 0 forks source link

"removeOtherTrades":true no work for wanderer trader #5

Closed BlackAures1 closed 4 months ago

BlackAures1 commented 7 months ago

image image

Quark, Upgrade Uquatic, Apotheosis and other mods ignores "removeOtherTrades":true for a wandering trader. For regular villagers, it works 1.19.2 wanderer.json latest.log

SpaceCat97 commented 7 months ago

does it remove the vanilla trades?

BlackAures1 commented 7 months ago

It's supposed to delete it. If I understand correctly with regular residents it also removes mod trades. But with a roaming trader it doesn't. But maybe I haven't tested it thoroughly enough

SpaceCat97 commented 7 months ago

I'll do some testing

BlackAures1 commented 7 months ago

No news yet? 👉👈

SpaceCat97 commented 7 months ago

No, please understand that I do this in my spare time. This ticket will be updated when I have time to do so.

BlackAures1 commented 7 months ago

I'm sorry if that sounded harsh, I didn't plan to rush you. Just thought you had failed to replicate the bug/no function.

SpaceCat97 commented 5 months ago

I was able to recreate this issue in my dev environment. Will be fixed in the next release.

SpaceCat97 commented 5 months ago

I've added some functionality that will get rid of some modded trades, however different mods add trades in different ways (for example, quark forces trades). For mods that still add trades you will have to find a config option to disable them.

SpaceCat97 commented 4 months ago

Fixed in version 23 for all LTS versions