SpaceGroupUCL / depthmapX

depthmapX is a multi-platform Spatial Network Analysis Software
198 stars 52 forks source link

Allow "unmaking" the VGA graph #283

Closed pklampros closed 5 years ago

pklampros commented 5 years ago

This allows a user to go back to the "filling" process without losing what's already covered. It will reset all attributes and data and links. This is to address the first stages of the VGA process, where a space is filled, its graph made and linked. In the last stage (linking) it is very likely a space is discovered that has not been filled. The change suggested here allows clearing the processed points in order to fill the missing space and thus re-make the graph and continue the process. The links are not kept so in the above process, before unmaking the graph, the links should be exported to a file and re-imported after re-making the graph with the newly filled space. This can potentially be remedied if we allow the links to be created even before the graph is made. In this case the "unfilling" process needs to also undo existing links. This will also set the points to "unblocked", thus, if a graph is made, unmade and has its underlying lines changed then if made again the new lines will be used.

This change also allows for linking to be done earlier in the process (during/after filling), and asks the user whether they want to remove the links when unmaking the graph.

Finally it allows the GLView to remove fills (and clear the relevant links) using the right mouse button and the pencil tool in line with the legacy view

If these processes (filling/making graph and linking) are to be completely decoupled, maybe the links should not be cleared at all when unmaking the graph and instead a separate menu item can be provided, given that this is an unlikely event. Any thoughts on this?