Make sure the key column actually gets a name

SpaceGroupUCL / depthmapX

depthmapX is a multi-platform Spatial Network Analysis Software

197 stars 52 forks source link

Make sure the key column actually gets a name #355

Closed pklampros closed 4 years ago

pklampros commented 4 years ago

In fact, this string is referenced in various other places so it would make sense to have a way to refer to it.. Should I introduce a static std::string keyRefAttribute = "Ref" in the class?

blsemo commented 4 years ago

Introducing a constant for that column name sounds like a good idea. Introducing a non-const static member in the class sounds crazy. How about a const std::string or even a char const * const in a namespace?