search

SpaceGroupUCL / qgisSpaceSyntaxToolkit

Space Syntax Toolkit for QGIS
GNU General Public License v3.0
115 stars 40 forks source link

Enables the progress bar when running analysis with DepthNetEngine #207

Closed n-bristow closed 10 months ago

n-bristow commented 10 months ago

While #194 suppresses the AttributeError: 'DepthmapNetEngine' object has no attribute 'analysis_nodes' it doesn't enable the updating of the progress bar. This pull request enables the progress bar in QGIS to be updated and displayed properly when running analysis using depthmapXnet35 in the SSx Toolkit. Potentially resolves #164.

Moves the statement extracting progress and introduces a couple of elif statements to parse the msg coming from DepthMap and enable the updating of the progress bar in QGIS when running analysis through the SSx Toolkit.

n-bristow commented 10 months ago

@jorgegil I have created this pull request which, combined with #194, should fix the progress bar. It's hopefully a pretty minor fix but I'm not clear if there are any testing procedures (automated/manual) that this should/will go through?

If this does work it would be nice to get it included in the zip as then I think more people would be interested in testing the zip before it gets published to QGIS. Thanks again for your help with this.

jorgegil commented 10 months ago

The only testing procedure we do is manual (especially when it comes to GUI features) and involves running the different analysis with the sample data set.

I will try to test and include it in the release.

n-bristow commented 10 months ago

That's great, thank you. I'll try and get some more testing done and come back to you!