SpaceK33z / web-to-plex

🚠 Adds a button on various movie & TV show sites to open it in Plex.
Other
121 stars 18 forks source link

Issue: Foreign Titles #121

Closed Ephellon closed 4 years ago

Ephellon commented 4 years ago

...[There are 2 issues I still have]: the extension gets deleted every single time Firefox restarts; that might be due to the way developer settings are designed (but settings remain). [F]oreign titles struggle to get a match in the extension even if they exist in Radarr.

Originally posted by @NicoLeOca in #104.546454106

Ephellon commented 4 years ago

@NicoLeOca, could you send me some examples please? I'll check and see if the problem still exists.

Ephellon commented 4 years ago

As for the deletion, yes, Firefox is designed to do that. If you want the extension permanetly, install the Firefox Extension (XPI).

NicoLeOca commented 4 years ago

Hi @Ephellon Firefox (public version) doesn't allow the installation of not-signed extension.

So I installed chrome, but the extension gets many errors there. I am pretty stuck

Ephellon commented 4 years ago

Hi, sorry, just woke up. Could you give me more information please?

Ephellon commented 4 years ago

For Firefox (cite, and cite), it seems I just need to uncomment the update_url.

NicoLeOca commented 4 years ago

@Ephellon Please have a look here. https://support.mozilla.org/en-US/kb/add-on-signing-in-firefox

Ephellon commented 4 years ago

@NicoLeOca, could you send me some examples please? I'll check and see if the problem still exists.

NicoLeOca commented 4 years ago

@Ephellon i'd like to but, as said earlier, I can't install the extension anymore Do you have a link to a version that I could install, either on Firefox or Chrome, please?

Ephellon commented 4 years ago

Yes, please see the master branch and choose the .XPI or .CRX file (or .ZIP), and follow the installation instructions (Wiki)

NicoLeOca commented 4 years ago

@Ephellon exactly what I did

Online (CRX/XPI/JAR) — Stable/BETA when I click on XPI (for Firefox of course), I get the chance to download the file, but I am not offered to install it. With Chrome I can open the CRX, only download too.

Online (ZIP) — Stable/BETA I get a popup from Firefox says that I can't install this module because it has not been verified With chrome, it says that it can't load the extension icon.

Ephellon commented 4 years ago

Ok, I'll check on it when I get home

Ephellon commented 4 years ago

I'll resign the extensions... maybe an hour or so?

NicoLeOca commented 4 years ago

anytime

Ephellon commented 4 years ago

Sorry, was in a queue for signing... try here (Firefox)

NicoLeOca commented 4 years ago

Thanks @Ephellon Extension installed. However, I could not get it to work properly

It's connected to Plex. The connection to Radarr seems to be working but I can't switch it on.

Also, either when I go to trakt or to Allocine, on a movies that I am supposed to have in Plex, the colored dot of the extension remain red. What is this dot supposed to display?

Ephellon commented 4 years ago

Red means an error occurred. Let me check on it again

NicoLeOca commented 4 years ago

take your time I get off to bed

Ephellon commented 4 years ago

OK, will resign... Will push in a few

Ephellon commented 4 years ago

Ah. There are multiple elements of the same information... Fixing it now

Ephellon commented 4 years ago

Got it. Pushing, again. Available here (Firefox).

NicoLeOca commented 4 years ago

it is working now on trakt but not on allociné (the dot is red) I am not sure where the issue is

Ephellon commented 4 years ago

Send me the URL, I'll check on it

Ephellon commented 4 years ago

Also, what settings do you have enabled?

NicoLeOca commented 4 years ago

http://www.allocine.fr/film/fichefilm_gen_cfilm=185719.html

Enabled settings are Plex, Radarr, Sonarr, Allociné and Trakt

Ephellon commented 4 years ago

Got the same error!

Ephellon commented 4 years ago

Found the error (Searching Error): ⊘ No information was found for "Bohemian Rhapsody (2018)"

image

Ephellon commented 4 years ago

Found the error! .../3/search/{ "movie", "tv" } but was using .../3/search/{ "film" }

Ephellon commented 4 years ago

Temporary fix (until next push): enable Manager Searching (Other Settings | Search Settings)

NicoLeOca commented 4 years ago

Hi @Ephellon The proposed fix doesn't change anything, I still get the red dot

Ephellon commented 4 years ago

Noted

Ephellon commented 4 years ago

I'll push the suspected fix, give me 10min

Ephellon commented 4 years ago

Pushed... Waiting in queue (6 of 6)

Ephellon commented 4 years ago

Signed. Please update and try the suspected fix: Web 2 Plex

NicoLeOca commented 4 years ago

working! 👍 thanks for your active support

Ephellon commented 4 years ago

Glad to hear. Don't hesitate to send more issues! Thanks for the help 🤠

NicoLeOca commented 4 years ago

Hi @Ephellon I get a red dot with a few movies on Allocine http://www.allocine.fr/film/fichefilm_gen_cfilm=222451.html http://www.allocine.fr/film/fichefilm_gen_cfilm=255238.html http://www.allocine.fr/film/fichefilm_gen_cfilm=262396.html

Do you know why?

Ephellon commented 4 years ago

Yes, the titles are too different:

image

Ephellon commented 4 years ago

To "fix," adjust your Loose matching settings.


Strict Matching - false (not exact) Title Matching - false (not equal) Loose Matching - 12% match (French v. English), 9% match (English v. French)

Ephellon commented 4 years ago

Be careful though, setting this too low will match false positives

NicoLeOca commented 4 years ago

thanks @Ephellon I'll stick to stick match though In a perfect world, a nice improvement would be to have a list of possibilites to choose from ;-)

Ephellon commented 4 years ago

Added "Search on fail" to let the user choose a correction when Web to Plex can't find an item

One possible correction found image

Multiple possible corrections found image

NicoLeOca commented 4 years ago

👍 I will give it a try

Ephellon commented 4 years ago

I'll make a few more adjustments, might push v4.1.1.9 later on this week