search

SpaceK33z / web-to-plex

🚠 Adds a button on various movie & TV show sites to open it in Plex.
Other
122 stars 18 forks source link

Pre-upgrade to v4 #54

Closed Ephellon closed 6 years ago

Ephellon commented 6 years ago

Hi @SpaceK33z, I've made most of the changes noted in your comment here, with the following not done:

Not Done

What Why
remove adblockplus.txt I was planning on using it as a custom filter list; but that's later on
installed make I'm not sure how to use make yet
made comment changes I need to re-read the code and add comments for human readability
SpaceK33z commented 6 years ago

This PR has conflicting changes so I can't merge it like this. Could you rebase it on the latest master commit and then apply your changes? Maybe the simplest way would be to just clone SpaceK33z/web-to-plex again, remove all files in it and copy/paste your files from your fork and commit.

I was planning on using it as a custom filter list; but that's later on

Okay sure, if it's documented later on that's also fine, it was just confusing for me since there was no reference to this file in either the documentation or the code.

I'm not sure how to use make yet

make is a build tool a bit like Gulp (but way older than that). I have no attachment to using make so I'm fine with replacing it. But we can do that at the same time as we automate the release process (I realllly want to be able to just push the code to GitHub, and have the extension automatically uploaded to the Chrome and FireFox store). So anyway, you wouldn't need to learn it (it may be a handy skill to have though!).