remove the if statement that is always 'false'

SpaceMadness / lunar-unity-console

High-performance Unity iOS/Android logger built with native platform UI

https://www.assetstore.unity3d.com/en/#!/content/43800

Other

839 stars 114 forks source link

remove the if statement that is always 'false' #144

Closed xuejiangtao closed 3 years ago

xuejiangtao commented 5 years ago

hello, i found a Code Quality Issue for this file that Conditions should not unconditionally evaluate to "TRUE" or to "FALSE". previous condition IsEnabled && (collection != null && collection.contains(expected)) ensures the collection is not null. so the collection == null is always false and the code AssertHelper("Assertion failed: collection is null"); will never be executed. https://rules.sonarsource.com/java/type/Bug/RSPEC-1145

weeeBox commented 4 years ago

Hey @xuejiangtao,

Sorry for the late reply. Would you be able to sign the Individual Contributor License Agreement (CLA)?