SpaceMadness / lunar-unity-console

High-performance Unity iOS/Android logger built with native platform UI
https://www.assetstore.unity3d.com/en/#!/content/43800
Other
833 stars 112 forks source link

Unity 2020.3 LTS #192

Closed re-cheid closed 3 years ago

re-cheid commented 3 years ago

Just upgraded to Unity 2020.3.0 f1 LTS version, and it seems that the CallbackFunction definition in AndroidPlugin.cs need to be adjusted again.

Currently it is:

#if UNITY_2020_1_OR_NEWER
using CallbackFunction = System.Action;
#else
using CallbackFunction = UnityEditor.EditorApplication.CallbackFunction;
#endif

which causes compile errors, found that the UnityEditor.EditorApplication.CallbackFunction definition works with that unity version

weeeBox commented 3 years ago

Hi @re-cheid,

I'll take a look - thanks for reporting!

weeeBox commented 3 years ago

@re-cheid, everything builds fine on both mac and windows - can you confirm you still facing the issue?

re-cheid commented 3 years ago

Hi, sorry for the late response.

I checked it again with Unity 2020.3.9 LTS and the latest version of lunar console pro. The issue seems to be gone now.

Bobby-RobertQ commented 2 years ago

can i get someone to check that this didnt just happen again in 2020.3.25f1

if UNITY_2020_1_OR_NEWER