Variables Removal - Githubissues

SpaceMadness / lunar-unity-console

High-performance Unity iOS/Android logger built with native platform UI

https://www.assetstore.unity3d.com/en/#!/content/43800

Other

833 stars 112 forks source link

Variables Removal #195

Open Vukiz opened 3 years ago

Vukiz commented 3 years ago

added support to remove variables It can be used to create dynamic menus in plugin - so you can add or remove variables on button clicked.

weeeBox commented 3 years ago

Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging:

Can you fix the broken unit test ion iOS: Native/iOS/LunarConsole/LunarConsoleTests/LUActionRegistryFilterTest.swift:54:7: Type 'LUActionRegistryFilterTest' does not conform to protocol 'LUActionRegistryFilterDelegate'?
Can you sign the Individual Contributor License Agreement (CLA)?

Vukiz commented 3 years ago

Hey, @weeeBox! Finally won in a battle of me vs syntax. Fixed issues with tests and signed CLA.

weeeBox commented 3 years ago

@Vukiz, cool - thanks! Things are a bit busy on my end right now - I'll try to review and merge until the end of the week!

weeeBox commented 3 years ago

@Vukiz, why do we need a projmods file here: Native/iOS/LunarConsole/LunarConsole/Lunar.projmods?

Vukiz commented 3 years ago

@Vukiz, why do we need a projmods file here: Native/iOS/LunarConsole/LunarConsole/Lunar.projmods?

Seems like I'm using XUPorter(https://github.com/onevcat/XUPorter) without knowing it. Without .projmods file after build xcode project I need to manually add Lunar lib to xcode project or to write a postprocessor so this files would be linked. Should I delete this file?

weeeBox commented 3 years ago

There's a build post-processor already. I think we can delete the projmods file.

Vukiz commented 3 years ago

Yeah, for some reason that didn't work in my projects. Removed this file anyways.