Open Vukiz opened 3 years ago
Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging:
Native/iOS/LunarConsole/LunarConsoleTests/LUActionRegistryFilterTest.swift:54:7: Type 'LUActionRegistryFilterTest' does not conform to protocol 'LUActionRegistryFilterDelegate'
?Hey, @weeeBox! Finally won in a battle of me vs syntax. Fixed issues with tests and signed CLA.
@Vukiz, cool - thanks! Things are a bit busy on my end right now - I'll try to review and merge until the end of the week!
@Vukiz, why do we need a projmods
file here: Native/iOS/LunarConsole/LunarConsole/Lunar.projmods
?
@Vukiz, why do we need a
projmods
file here:Native/iOS/LunarConsole/LunarConsole/Lunar.projmods
?
Seems like I'm using XUPorter(https://github.com/onevcat/XUPorter) without knowing it. Without .projmods file after build xcode project I need to manually add Lunar lib to xcode project or to write a postprocessor so this files would be linked. Should I delete this file?
There's a build post-processor already. I think we can delete the projmods
file.
Yeah, for some reason that didn't work in my projects. Removed this file anyways.
added support to remove variables It can be used to create dynamic menus in plugin - so you can add or remove variables on button clicked.