Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging: - Githubissues

SpaceMadness / lunar-unity-console

High-performance Unity iOS/Android logger built with native platform UI

https://www.assetstore.unity3d.com/en/#!/content/43800

Other

833 stars 112 forks source link

Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging: #208

Closed alikia19 closed 2 years ago

alikia19 commented 2 years ago

Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging:

Can you fix the broken unit test ion iOS: Native/iOS/LunarConsole/LunarConsoleTests/LUActionRegistryFilterTest.swift:54:7: Type 'LUActionRegistryFilterTest' does not conform to protocol 'LUActionRegistryFilterDelegate'?
Can you sign the Individual Contributor License Agreement (CLA)?

Originally posted by @weeeBox in https://github.com/SpaceMadness/lunar-unity-console/issues/195#issuecomment-835830876