/mutable_appearance should have more vars than /image + opacity

SpaceManiac / SpacemanDMM

A BYOND language smartness provider, map renderer, and more.

https://marketplace.visualstudio.com/items?itemName=platymuus.dm-langclient

GNU General Public License v3.0

83 stars 83 forks source link

/mutable_appearance should have more vars than /image + opacity #186

Closed Kaiochao closed 4 years ago

Kaiochao commented 4 years ago

https://github.com/SpaceManiac/SpacemanDMM/blob/35915f7cb9dc65c8450e43352eb5a2676f97d37f/src/dreammaker/builtins.rs#L941-L942

SpaceManiac commented 4 years ago

like what

Kaiochao commented 4 years ago

Well, just from difference in what the docs show for vars (mutable_appearance) and vars (image):

/mutable_appearance vars that /image isn't documented to have:

density
desc
gender
invisibility
layer
luminosity
animate_movement
mouse_over_pointer
mouse_drag_pointer
mouse_drop_pointer
mouse_drop_zone
mouse_opacity
name
opacity (got this one already, nice)
screen_loc
suffix
verbs
vis_flags

/image vars that /mutable_appearance isn't documented to have:

loc
override
render_source
render_target
vis_contents
x
y
z
type
tag
parent_type

SpaceManiac commented 4 years ago

The docs have this to say:

The /mutable_appearance datum is technically a descendant of /image, but this is only for convenience, and should not be relied on for any other purpose as it is subject to change in future versions.

I have to strike a balance between implementing DM as documented and implementing DM as actually used. In this case I will be making available the same set of vars on /image and on /mutable_appearance that the DM compiler does.