search

SpaceManiac / SpacemanDMM

A BYOND language smartness provider, map renderer, and more.
https://marketplace.visualstudio.com/items?itemName=platymuus.dm-langclient
GNU General Public License v3.0
83 stars 83 forks source link

Output from "dmm-tools check" is just wrong #31

Closed DamianX closed 6 years ago

DamianX commented 6 years ago

Running SpacemanDMM 9b0c9c8b6375143c0df6230c68eef7d8c7fbba21 against https://github.com/vgstation-coders/vgstation13/commit/006ce38c3d023872c1c9594087ce8348b814184e

Click me ``` dmm-tools check parsing vgstation13.dme __DEFINES/planes+layers.dm, line 94, column 10: warning: macro redefined: HOLOMAP_LAYER __DEFINES/planes+layers.dm, line 79, column 10: info: previous definition of HOLOMAP_LAYER __DEFINES/reagents.dm, line 190, column 9: warning: macro redefined: RUM __DEFINES/reagents.dm, line 188, column 9: info: previous definition of RUM __DEFINES/reagents.dm, line 250, column 9: warning: macro redefined: CHANGELINGSTING __DEFINES/reagents.dm, line 220, column 9: info: previous definition of CHANGELINGSTING __DEFINES/setup.dm, line 770, column 9: warning: macro redefined: BRUTE __DEFINES/setup.dm, line 610, column 9: info: previous definition of BRUTE __DEFINES/setup.dm, line 771, column 9: warning: macro redefined: BURN __DEFINES/setup.dm, line 611, column 9: info: previous definition of BURN __DEFINES/setup.dm, line 772, column 9: warning: macro redefined: TOX __DEFINES/setup.dm, line 612, column 9: info: previous definition of TOX __DEFINES/setup.dm, line 773, column 9: warning: macro redefined: OXY __DEFINES/setup.dm, line 613, column 9: info: previous definition of OXY __DEFINES/setup.dm, line 774, column 9: warning: macro redefined: CLONE __DEFINES/setup.dm, line 614, column 9: info: previous definition of CLONE __DEFINES/setup.dm, line 775, column 9: warning: macro redefined: HALLOSS __DEFINES/setup.dm, line 615, column 9: info: previous definition of HALLOSS __DEFINES/setup.dm, line 777, column 9: warning: macro redefined: STUN __DEFINES/setup.dm, line 618, column 9: info: previous definition of STUN __DEFINES/setup.dm, line 778, column 9: warning: macro redefined: WEAKEN __DEFINES/setup.dm, line 619, column 9: info: previous definition of WEAKEN __DEFINES/setup.dm, line 779, column 9: warning: macro redefined: PARALYZE __DEFINES/setup.dm, line 620, column 9: info: previous definition of PARALYZE __DEFINES/setup.dm, line 780, column 9: warning: macro redefined: IRRADIATE __DEFINES/setup.dm, line 621, column 9: info: previous definition of IRRADIATE __DEFINES/setup.dm, line 781, column 9: warning: macro redefined: STUTTER __DEFINES/setup.dm, line 623, column 9: info: previous definition of STUTTER __DEFINES/setup.dm, line 783, column 9: warning: macro redefined: EYE_BLUR __DEFINES/setup.dm, line 624, column 9: info: previous definition of EYE_BLUR __DEFINES/setup.dm, line 784, column 9: warning: macro redefined: DROWSY __DEFINES/setup.dm, line 625, column 9: info: previous definition of DROWSY __DEFINES/setup.dm, line 1204, column 9: warning: macro redefined: DAMAGE_LAYER __DEFINES/planes+layers.dm, line 211, column 10: info: previous definition of DAMAGE_LAYER __DEFINES/setup.dm, line 1338, column 2: error: unknown directive: #warning, did you mean #warn __DEFINES/setup.dm, line 1348, column 1: error: unknown directive: #warning, did you mean #warn __DEFINES/setup.dm, line 1359, column 7: error: got '*', expected one of: newline, '/', identifier ```

It claims HOLOMAP_LAYER is defined on line 94, but it's actually defined on line 98: https://github.com/vgstation-coders/vgstation13/blob/006ce38c3d023872c1c9594087ce8348b814184e/__DEFINES/planes%2Blayers.dm#L98 it also claims it's defined twice, on line 79, but it isn't https://github.com/vgstation-coders/vgstation13/blob/006ce38c3d023872c1c9594087ce8348b814184e/__DEFINES/planes%2Blayers.dm#L79

It's not just a case of wrong line numbers, I can't actually find any redefinition.

All of these warnings and the one error at the end seem to be wrong.

SpaceManiac commented 6 years ago

Unable to reproduce with the SpacemanDMM and vgstation13 commits you named, are you sure you've got the right vgstation version checked out? It seems like vgstation-coders/vgstation13@3d59f69e4ae526ef2db33c1ce9f67e2a2ae619a0 is supposed to have fixed these. My output contains various similar diagnostics, but they seem to at least have correct line numbers:

dmm-tools check output ``` parsing .\vgstation13.dme __DEFINES/setup.dm, line 1262, column 2: error: unknown directive: #warning, did you mean #warn __DEFINES/setup.dm, line 1272, column 1: error: unknown directive: #warning, did you mean #warn code/__HELPERS/game.dm, line 283, column 1: error: unknown directive: #warning, did you mean #warn code/game/machinery/bots/secbot.dm, line 31, column 9: warning: macro redefined: SECBOT_IDLE code/game/machinery/bots/ed209bot.dm, line 37, column 9: info: previous definition of SECBOT_IDLE code/game/machinery/bots/secbot.dm, line 32, column 9: warning: macro redefined: SECBOT_HUNT code/game/machinery/bots/ed209bot.dm, line 38, column 9: info: previous definition of SECBOT_HUNT code/game/machinery/bots/secbot.dm, line 33, column 9: warning: macro redefined: SECBOT_PREP_ARREST code/game/machinery/bots/ed209bot.dm, line 39, column 9: info: previous definition of SECBOT_PREP_ARREST code/game/machinery/bots/secbot.dm, line 34, column 9: warning: macro redefined: SECBOT_ARREST code/game/machinery/bots/ed209bot.dm, line 40, column 9: info: previous definition of SECBOT_ARREST code/game/machinery/bots/secbot.dm, line 35, column 9: warning: macro redefined: SECBOT_START_PATROL code/game/machinery/bots/ed209bot.dm, line 41, column 9: info: previous definition of SECBOT_START_PATROL code/game/machinery/bots/secbot.dm, line 36, column 9: warning: macro redefined: SECBOT_PATROL code/game/machinery/bots/ed209bot.dm, line 42, column 9: info: previous definition of SECBOT_PATROL code/game/machinery/bots/secbot.dm, line 37, column 9: warning: macro redefined: SECBOT_SUMMON code/game/machinery/bots/ed209bot.dm, line 43, column 9: info: previous definition of SECBOT_SUMMON code/game/machinery/computer/slot_machine.dm, line 3, column 2: error: unknown directive: #warning, did you mean #warn code/game/objects/effects/beam.dm, line 22, column 1: error: unknown directive: #warning, did you mean #warn code/game/objects/items/crayons.dm, line 145, column 42: warning: macro "MAX_LETTERS" used immediately before being undefined: https://secure.byond.com/forum/?post=2072419 code/game/objects/items/devices/lightreplacer.dm, line 36, column 9: warning: macro redefined: LIGHT_OK __DEFINES/lighting.dm, line 72, column 9: info: previous definition of LIGHT_OK code/game/objects/items/devices/lightreplacer.dm, line 37, column 9: warning: macro redefined: LIGHT_EMPTY __DEFINES/lighting.dm, line 73, column 9: info: previous definition of LIGHT_EMPTY code/game/objects/items/devices/lightreplacer.dm, line 38, column 9: warning: macro redefined: LIGHT_BROKEN __DEFINES/lighting.dm, line 74, column 9: info: previous definition of LIGHT_BROKEN code/game/objects/items/devices/lightreplacer.dm, line 39, column 9: warning: macro redefined: LIGHT_BURNED __DEFINES/lighting.dm, line 75, column 9: info: previous definition of LIGHT_BURNED code/game/objects/items/robot/robot_items/robot_hug.dm, line 3, column 9: warning: macro redefined: SHOCK __DEFINES/setup.dm, line 510, column 9: info: previous definition of SHOCK code/game/objects/structures/curtains.dm, line 106, column 8: warning: macro undefined while not defined: SHOWER_OPEN_LAYER code/game/objects/structures/curtains.dm, line 107, column 8: warning: macro undefined while not defined: SHOWER_CLOSED_LAYER code/game/turfs/unsimulated/snow.dm, line 3, column 9: warning: macro redefined: ARCTIC_ATMOSPHERE code/game/turfs/simulated/snow.dm, line 3, column 9: info: previous definition of ARCTIC_ATMOSPHERE code/game/turfs/unsimulated/snow.dm, line 4, column 9: warning: macro redefined: T_ARCTIC code/game/turfs/simulated/snow.dm, line 4, column 9: info: previous definition of T_ARCTIC code/game/turfs/unsimulated/snow.dm, line 5, column 9: warning: macro redefined: MOLES_ARCTICSTANDARD code/game/turfs/simulated/snow.dm, line 5, column 9: info: previous definition of MOLES_ARCTICSTANDARD code/game/turfs/unsimulated/snow.dm, line 6, column 9: warning: macro redefined: MOLES_O2STANDARD_ARCTIC code/game/turfs/simulated/snow.dm, line 6, column 9: info: previous definition of MOLES_O2STANDARD_ARCTIC code/game/turfs/unsimulated/snow.dm, line 7, column 9: warning: macro redefined: MOLES_N2STANDARD_ARCTIC code/game/turfs/simulated/snow.dm, line 7, column 9: info: previous definition of MOLES_N2STANDARD_ARCTIC code/modules/admin/verbs/diagnostics.dm, line 98, column 8: warning: macro undefined while not defined: GATHER_DELAYER_LOCKUPS code/modules/admin/verbs/massmodvar.dm, line 121, column 9: warning: macro undefined while not defined: perform code/modules/admin/verbs/profiling.dm, line 23, column 1: warning: macro "gen_disable_proc" used immediately before being undefined: https://secure.byond.com/forum/?post=2072419 code/modules/client/preferences.dm, line 73, column 9: warning: macro redefined: GET_RANDOM_JOB code/game/jobs/job_controller.dm, line 3, column 9: info: previous definition of GET_RANDOM_JOB code/modules/client/preferences.dm, line 74, column 9: warning: macro redefined: BE_ASSISTANT code/game/jobs/job_controller.dm, line 4, column 9: info: previous definition of BE_ASSISTANT code/modules/client/preferences.dm, line 75, column 9: warning: macro redefined: RETURN_TO_LOBBY code/game/jobs/job_controller.dm, line 5, column 9: info: previous definition of RETURN_TO_LOBBY code/modules/clothing/masks/chemmask.dm, line 24, column 9: warning: macro redefined: TIME code/libs/db/constants.dm, line 35, column 9: info: previous definition of TIME code/modules/Economy/Economy.dm, line 28, column 9: warning: macro redefined: DEFAULT __DEFINES/setup.dm, line 1484, column 9: info: previous definition of DEFAULT code/modules/media/jukebox.dm, line 9, column 9: warning: macro redefined: JUKEMODE_PLAY_ONCE code/datums/wires/jukebox.dm, line 1, column 9: info: previous definition of JUKEMODE_PLAY_ONCE code/modules/media/mediamanager.dm, line 131, column 1: error: unknown directive: #warning, did you mean #warn code/modules/mob/inventory.dm, line 33, column 9: warning: macro redefined: is_valid_hand_index __DEFINES/setup.dm, line 281, column 9: info: previous definition of is_valid_hand_index code/modules/mob/living/carbon/alien/alien.dm, line 1, column 9: warning: macro redefined: HEAT_DAMAGE_LEVEL_1 code/modules/mob/living/carbon/_defines.dm, line 5, column 9: info: previous definition of HEAT_DAMAGE_LEVEL_1 code/modules/mob/living/carbon/alien/alien.dm, line 2, column 9: warning: macro redefined: HEAT_DAMAGE_LEVEL_2 code/modules/mob/living/carbon/_defines.dm, line 6, column 9: info: previous definition of HEAT_DAMAGE_LEVEL_2 code/modules/mob/living/carbon/alien/alien.dm, line 3, column 9: warning: macro redefined: HEAT_DAMAGE_LEVEL_3 code/modules/mob/living/carbon/_defines.dm, line 7, column 9: info: previous definition of HEAT_DAMAGE_LEVEL_3 code/modules/mob/living/carbon/alien/humanoid/update_icons.dm, line 6, column 9: warning: macro redefined: TARGETED_LAYER __DEFINES/setup.dm, line 1200, column 9: info: previous definition of TARGETED_LAYER code/modules/mob/living/carbon/alien/humanoid/update_icons.dm, line 147, column 21: warning: macro "X_FIRE_LAYER" used immediately before being undefined: https://secure.byond.com/forum/?post=2072419 code/modules/mob/living/carbon/human/examine.dm, line 467, column 8: warning: macro undefined while not defined: Jitter_Medium code/modules/mob/living/carbon/human/examine.dm, line 468, column 8: warning: macro undefined while not defined: Jitter_High code/modules/mob/living/carbon/monkey/update_icons.dm, line 11, column 9: warning: macro redefined: TARGETED_LAYER __DEFINES/setup.dm, line 1200, column 9: info: previous definition of TARGETED_LAYER code/modules/mob/living/carbon/monkey/update_icons.dm, line 317, column 21: warning: macro "M_FIRE_LAYER" used immediately before being undefined: https://secure.byond.com/forum/?post=2072419 code/modules/mob/living/simple_animal/hostile/necro.dm, line 719, column 8: warning: macro undefined while not defined: EVOLVING code/modules/mob/living/simple_animal/hostile/necro.dm, line 720, column 8: warning: macro undefined while not defined: MOVING_TO_TARGET code/modules/mob/living/simple_animal/hostile/necro.dm, line 721, column 8: warning: macro undefined while not defined: EATING code/modules/mob/living/simple_animal/hostile/necro.dm, line 722, column 8: warning: macro undefined while not defined: OPENING_DOOR code/modules/mob/living/simple_animal/hostile/wolf.dm, line 16, column 9: warning: macro redefined: MOVECOST code/modules/mob/living/simple_animal/friendly/mouse.dm, line 5, column 9: info: previous definition of MOVECOST code/modules/mob/living/simple_animal/hostile/wolf.dm, line 17, column 9: warning: macro redefined: STANDCOST code/modules/mob/living/simple_animal/friendly/mouse.dm, line 6, column 9: info: previous definition of STANDCOST code/modules/power/singularity/singularity.dm, line 40, column 5: error: got ':', expected one of: '/', '[', contents, newline, '}', identifier code/modules/mob/living/living_defines.dm, line 50, column 10: error: undefined var 'on_fire' on type '/mob/living' ignoring further errors of this type due to earlier parse failures code/game/machinery/chemHandC.dm, line 17, column 22: error: out-of-range Pow: 10 ** 32 code/modules/mob/living/simple_animal/hostile/mining_mobs.dm, line 620, column 14: error: out-of-range Pow: 10 ** 32 ```
DamianX commented 6 years ago

Wow. I was indeed using an entirely different repo.