Closed danielschloms closed 7 months ago
Attention: Patch coverage is 98.38710%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 88.36%. Comparing base (
d9fd1c0
) to head (42ec759
).
Files | Patch % | Lines |
---|---|---|
Sts1CobcSw/Utility/FlatArray.hpp | 88.88% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
While one comment mentions not to use trailing comments, the "layout" of the Initialize()
function with comments right beside the property values would make it very easy to spot and change single values, if that were needed later.
Description
This PR
SetProperties()
andSendCommand()
. Furthermore, the obvious magic values have been moved into constants, and the delays in the SPI communication have been removed.FlatArray()
, a function to create a flatstd::array
from values, arrays, spans, or a mix thereof.#includes
according to IWYU.Fixes #224