SpaceTeam / STS1_COBC_SW

Software for the communication and onboard computer (COBC) of SpaceTeamSat1 (STS1)
MIT License
10 stars 2 forks source link

Refactor RF initialize function #256

Closed danielschloms closed 7 months ago

danielschloms commented 8 months ago

Description

This PR

Fixes #224

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 98.38710% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.36%. Comparing base (d9fd1c0) to head (42ec759).

Files Patch % Lines
Sts1CobcSw/Utility/FlatArray.hpp 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #256 +/- ## ========================================== + Coverage 87.15% 88.36% +1.20% ========================================== Files 18 20 +2 Lines 514 576 +62 ========================================== + Hits 448 509 +61 - Misses 66 67 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielschloms commented 8 months ago

While one comment mentions not to use trailing comments, the "layout" of the Initialize() function with comments right beside the property values would make it very easy to spot and change single values, if that were needed later.