Something like using ProgramId = fluent::NamedType<std::uint16_t, struct ProgramIdTag>; should do the trick. This type makes interfaces safer, as in easier to use correctly and more difficult to use incorrectly. Since the program ID shows up in a lot of files and also gets serialized, this refactoring is probably quite some work, but the longer we wait, the worse it gets. We also have to think about where we actually define the type. It will be used at least in the modules for the EDU, the file system and the RF command handling, so it should be in a separate component, but I am not sure what to call it yet since I don't know if and which other types might join later. We could use something like Sts1CobcSw/StrongTypedefs/StrongTypedefs.hpp or .../CommonTypes/CommonTypes.hpp or we think about the umbrella term later and just use .../ProgramId/ProgramId.hpp. I really don't know.
PatrickKa
commented
6 days ago
Description
Something like
using ProgramId = fluent::NamedType<std::uint16_t, struct ProgramIdTag>;should do the trick. This type makes interfaces safer, as in easier to use correctly and more difficult to use incorrectly. Since the program ID shows up in a lot of files and also gets serialized, this refactoring is probably quite some work, but the longer we wait, the worse it gets. We also have to think about where we actually define the type. It will be used at least in the modules for the EDU, the file system and the RF command handling, so it should be in a separate component, but I am not sure what to call it yet since I don't know if and which other types might join later. We could use something likeSts1CobcSw/StrongTypedefs/StrongTypedefs.hppor.../CommonTypes/CommonTypes.hppor we think about the umbrella term later and just use.../ProgramId/ProgramId.hpp. I really don't know.