Implement reset function for EPS sensors

SpaceTeam / STS1_COBC_SW

Software for the communication and onboard computer (COBC) of SpaceTeamSat1 (STS1)

MIT License

10 stars 2 forks source link

Implement reset function for EPS sensors #279

Closed danielschloms closed 6 months ago

danielschloms commented 7 months ago

Description

This PR adds functionality to either fully reset the ADCs to their default power up state, or just clear the FIFOs.

Fixes #214

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.36%. Comparing base (b159fe5) to head (3889373).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================== - Coverage 89.28% 88.36% -0.92% ========================================== Files 22 20 -2 Lines 625 576 -49 ========================================== - Hits 558 509 -49 Misses 67 67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PatrickKa commented 7 months ago

I did not close this PR on purpose. It was just a mistake during force pushing.

PatrickKa commented 7 months ago

I don't know why LfsRam.test.cpp fails all of a sudden. I did not change any code there. The EPS code is not even built for Linux. I also cannot reproduce the error locally. I used the same container version, deleted the build folder, and executed the same commands as for the test job. Still, all tests passed. This is super weird. I don't know what to do, so I'll just wait and run the tests again later or tomorrow. Hopefully that the problem has resolved itself then.

PatrickKa commented 7 months ago

WTF. I reverted the single commit that I made on this branch. This is now the same code as on the master branch which passed all tests just fine on 21.04.2024.

PatrickKa commented 6 months ago

I created a separate issue for the problem with the LfsRam test (#281) and disabled the test for now, so that this doesn't stop all other progress.