search

SpaceTradersAPI / api-docs

The API documentation for the SpaceTraders API
143 stars 36 forks source link

Inconsistency in OpenAPI spec #50

Closed Heysem closed 1 year ago

Heysem commented 1 year ago

Hello,

I noticed an inconsistency between 2 endpoints when generating an openapi client. The endpoints in question are both POST request and require no body to be sent. The first one: /my/ships/{shipSymbol}/dock Has no "requestBody" defined in the openAPI spec

However the second one: "/my/ships/{shipSymbol}/negotiate/contract"

Requires an empty requestBody: "requestBody": { "content": { "application/json": { "schema": {} } } } https://github.com/SpaceTradersAPI/api-docs/blob/main/reference/SpaceTraders.json#L2770

Wouldn't it make more sense to remove the "requestBody" from the latter endpoint as well?

space-admiral commented 1 year ago

Absolutely! Thanks for catching this. Going to push a fix now.