search

SpaceTradersAPI / issues-and-suggestions

16 stars 1 forks source link

spaceAvailable not calculating correctly with new volume inventory #57

Closed artokun closed 3 years ago

artokun commented 3 years ago

I just landed a PR that should have fixed it. Once I get it confirmed fix we can close this issue. @jadlers can you confirm?

jadlers commented 3 years ago

@artokun I'll keep my eyes open for confirmation from players!

jadlers commented 3 years ago

@artokun It's not yet fixed properly. bchoii confirmed on Discord. There's over 1000 units of cargo with space for 300.

{
  id: 'ckm0cvtp71672zd89jv3v4q1f',
  cargo: [
    { good: 'FUEL', quantity: 15, totalVolume: 15 },
    { good: 'MACHINERY', quantity: 250, totalVolume: 1000 }
  ],
  spaceAvailable: 35,
  type: 'GR-MK-I',
  class: 'MK-I',
  maxCargo: 300,
}
jadlers commented 3 years ago

bchoii added a spreadsheat with data to help with fixing the issue: https://docs.google.com/spreadsheets/d/15Z8lHEtwRr2cyOB7gTHrM_E15mGNg_7yPa1C5AETFe8/edit#gid=1468807835