SpaceWarpDev / SpaceWarp

A C# modding API for KSP2
MIT License
91 stars 38 forks source link

[BUG] Mod config menus dont close correctly and interact weirdly #103

Closed KlaasWhite closed 1 year ago

KlaasWhite commented 1 year ago

Version Information

KSP 2 Version

0.1.0.0.20892

Space Warp Version

0.3.0


Bug Information

Describe the bug

When using the Mod menu on the main menu, some things go wrong. Firstly the buttons behind the window can be interacted with, which leads to overlapping menus, I dont know if this can be easily changed but I think it would be a more logical solution

The mod menu itself has no apparent way to be closed (except for clicking the mod menu button again which seems a weird way)

(This is caused by another bug which I will file a seperate report for, but still kind of a bug) More importantly, the Configure menu can not be closed (pressing the save and close button does nothing) and when pressing the Configure button again, another configuration menu opens, which seems counter intuitive. It seems like this is caused by a lack of config file, but i feel like it should still allow me to close the window

To Reproduce

Use the Mods menu, not much more to describe.

Expected behavior

This is a kind of both feature and bug report, I think I describe everything I would expect in the "Describe the bug" part.

Screenshots

image

Log

Ksp2.log

cheese3660 commented 1 year ago

For the first part, that would require a reimplementation of click through blocker which is under the LGPL license, meaning we'd likely have to port it in a separate repo under that license, compile it and have it as a dependency for space warp. Configuration menu closing is planned, once I figure out how to put a part of the menu on the title bar, or I could just add a close button at the bottom The inability to close is more so caused by the lack of a config folder in the mod directory

KlaasWhite commented 1 year ago

Is spacewarp supposed to add a config folder and file if they are not present or is that on the mod maker to make sure that it is there? Ill ask it here before I make a seperate post about it

cheese3660 commented 1 year ago

It should add a config folder and config file, right now it only does the latter

EwyBoy commented 1 year ago

Most of these issues should be fixed in the next version of SpaceWarp (v0.4.0) We hope to get #49 working very soon and we have also implemented #116 and #121 and also make some improvements to the closing UI logic.

EwyBoy commented 1 year ago

Marking this as resolved, as SpaceWarp v0.4.0 added the close button to the UI and you can also close all UI's by pressing ESC