Spacefish / powerdns-webinterface

Automatically exported from code.google.com/p/powerdns-webinterface
Apache License 2.0
10 stars 4 forks source link

Searches for only numbers return garbled HTML inside <td> elements (fix inside) #45

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. In demo, go to domain list.
2. Search for just a single character: the number 1
3. See garbled output, including the href attribute of anchors

What is the expected output? What do you see instead?
Expected output should not be garbled

What version of the product are you using? On what operating system?
1.5.3, CentOS 5.8, PHP 5.1

Please provide any additional information below.
I fixed the problem for the domain search. I have not looked at record search 
but I imagine the solution will be similar. My solution does not apply the 
"search_highlight" class to the "id" column of output in the "searchDomainlist" 
function in lib/Model/Domains.php. The line below is inserted after line 26 of 
that file (between the two assignments of ${colname}_clean and colname).

if (strcmp($colname,'id')==0) continue;

Original issue reported on code.google.com by james.t...@dominionenterprises.com on 3 Jan 2013 at 5:09

GoogleCodeExporter commented 9 years ago
I cloned the codebase and applied the change to my clone: 
http://code.google.com/r/jamestate-test/

Original comment by james.t...@dominionenterprises.com on 3 Jan 2013 at 5:14

GoogleCodeExporter commented 9 years ago
Oh yes well, the "highlight" code replaces some Javascript Code aswell.. thats 
not what i wanted

Original comment by timo.witte on 2 Mar 2013 at 2:14

GoogleCodeExporter commented 9 years ago
Thanks for your fix, i have merged your changes in master!

Original comment by timo.witte on 14 May 2013 at 4:47