search

Spacetime-Meta / spacetime-sdk

The spacetime-sdk is a turnkey virtual environment package for building in the Spacetime Metaverse
https://www.spacetimemeta.io/metaverse/spawn-planet
MIT License
11 stars 2 forks source link

Need help to reduce path reference #165

Closed codeeMadness closed 2 years ago

codeeMadness commented 2 years ago

Hi Liquid, As you know, ConnectionOptions.js met a problem too-long path when we do some actions relates to Github. We can totally deal with this when using some commands provided by Github. However, when I tried to deploy on internal server (I mean I have to place our core in server, not connected with any source control), it met the same issue. Should we change a little bit for this, to make the path shorter (such as move files to upper level folder)? Or could make the config inside the core to handle this issue?

Many thanks.

codeeMadness commented 2 years ago

Feel free to ignore if you feel no need

Liquid-Blocks commented 2 years ago

Hi @codeeMadness if it causes you a problem for the deployment I will reorganize the hierarchy to shorten the path.

codeeMadness commented 2 years ago

Hi @Liquid-Blocks, Many thanks

codeeMadness commented 2 years ago

Is there any way we can manage code structure using MVC model or other models? and we can control our files using name convention?

Liquid-Blocks commented 2 years ago

For the UI we can go toward something that is more MVC like, but I don't think we can fit the whole system into the MVC model since the VirtualEnvironment is somewhere between a controller and a view and we don't have specific entry point for the data.

codeeMadness commented 2 years ago

To be honest, For the UI, it's quite good. However for the code, it's quite heavy in structure, requires much nested class.

Liquid-Blocks commented 2 years ago

Hi @codeeMadness , the path was shorten in the PR #167. Does that solve your problem?

codeeMadness commented 2 years ago

many thanks. let me take a look on it.