search

Spacetime-Meta / spacetime-sdk

The spacetime-sdk is a turnkey virtual environment package for building in the Spacetime Metaverse
https://www.spacetimemeta.io/metaverse/spawn-planet
MIT License
11 stars 2 forks source link

161 update video call #166

Closed codeeMadness closed 2 years ago

codeeMadness commented 2 years ago

Hi,

This feature might have some bugs around. But basically, it follows new code styles.

Please help to review. I will try to cover bugs when open other issues. Feel free to reopen if need me to update some parts.

Regards,

Liquid-Blocks commented 2 years ago

Hi @codeeMadness, I have reviewed the call feature. It is getting a lot better and closer to a deployable state, but there are still some things that must be fixed before it can be merged to deployment.

Here is the list of my observations:

1. Red dot in browser tab after call ends image





2. The peer initiating the call does not see himself image





3. The callers information box options image I think the solution to this one would be to completely remove the information panel on the caller side. As shown in the picture bellow, the message contained in the information box could be used to fill the area where the other peers camera will go. image





4. Button style on the receiving side The button on the receiving side works well but the text should be replaced by standard answer and decline buttons since the yes/cancel options are not well adapted for the context but adapted to our style. image Here is the standard I mean, you can adapt it to our style as you want. image





Thank you

codeeMadness commented 2 years ago

Thanks for your feedback. Let me try to cover these issues.

Liquid-Blocks commented 2 years ago

I don think this is relevant anymore. Please open a new PR if you wish to include this feature in the Spacetime core sdk.

Thank you.