SpaceyaTech / SYT-Web-Redesign

https://www.spaceyatech.com/
Apache License 2.0
6 stars 23 forks source link

Fix accessibility issues #192

Closed alvyynm closed 1 week ago

alvyynm commented 1 week ago

Have you read the contributing guidelines ?

What is the purpose of your pull request?

Proposed changes

Most of the pages on the website have a medium acessibility rating (between 50 and 89, but the least I've seen is 76 and the highest 86), according to Google PageSpeed Insights.

I've addressed most of the accessibilty issues recommended and thus improved the rating to 96 (in the production build preview) for the following pages: /, /about-us, /events, /gallery, /blogs, /blogs:titleSlug, /community, and /products. I haven't touched /shop because i know there's a massive redesign on the way.

The main reason why the ratings can't reach 100 is because of our brand identity: there's ins't enough contrast ratio between background and foreground colors (the green background color with white text combo or vice versa).

Warning

Please read these points carefully and answer honestly with an X into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:34am
alvyynm commented 1 week ago

I've changed the base from Dev to main. I just realised I was pushing to it instead of main.