SpaceyaTech / SYT-Web-Redesign

https://www.spaceyatech.com/
Apache License 2.0
8 stars 25 forks source link

Fixes #197: Redesign shop single item view #207

Closed alvyynm closed 2 months ago

alvyynm commented 3 months ago

Have you read the contributing guidelines ?

What is the purpose of your pull request?

Proposed changes

This PR fixes #197.

It changes the design of a single item view from this πŸ‘‡:

https://github.com/SpaceyaTech/SYT-Web-Redesign/assets/40637276/e92cf7bd-fefd-4818-98ae-d81d1d24dea5

To this πŸ‘‡:

https://github.com/SpaceyaTech/SYT-Web-Redesign/assets/40637276/282461ee-2371-4059-9dee-896183239b26

Additionally, I've made some extra improvements:

NOTE

Warning

Please read these points carefully and answer honestly with an X into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
syt-web-redesign βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 9, 2024 8:28am
alvyynm commented 3 months ago

I've noticed there's a lot of merge conflicts with the Dev branch. Some changes included in #199 touch the entire shop section of the website. And, as we discussed with @sonylomo on WhatsApp, there's also style issues especially on the homepage.

Perhaps we can reverse #199 first? I know these will be hectic to resolve for anyone working on the shop and created a branch before the PR. I've tried it and I can't tell what to keep and what to remove (Or could it be a skill issue? πŸ˜†).

What do you guys think @sonylomo @bridgitkanini @Ase020

Ase020 commented 3 months ago

I've noticed there's a lot of merge conflicts with the Dev branch. Some changes included in #199 touch the entire shop section of the website. And, as we discussed with @sonylomo on WhatsApp, there's also style issues especially on the homepage.

Perhaps we can reverse #199 first? I know these will be hectic to resolve for anyone working on the shop and created a branch before the PR. I've tried it and I can't tell what to keep and what to remove (Or could it be a skill issue? πŸ˜†).

What do you guys think @sonylomo @bridgitkanini @Ase020

@alvyynm I've also noticed and tried to resolve the conflict on the Dev. I've seen dust there πŸ˜‚. We could schedule a meeting and come up with a way on how to handle. @JimmyOty is a good DevOps engineer he could also help us with this.

alvyynm commented 3 months ago

@Ase020 πŸ˜‚ I thought it's a skill issue on my end. Well, let's wait and see what other members have to say.