search

SpaceyaTech / SYT-Web-Redesign

https://www.spaceyatech.com/
Apache License 2.0
8 stars 23 forks source link

Linting and formatting checks are ever failing #212

Closed alvyynm closed 4 weeks ago

alvyynm commented 1 month ago

Since proper linting and formatting checks were added in #193, all of them have always failed. We should start addressing this. From build previews, the key issue we have is code formatting and linting (formatting is an easy fix but the latter requires a little bit of work to the codebase because it's manual).

We have checks in place for both in package.json, and we need to start enforcing these standards before approving PRs. So before someone's PR is approved, they should, among other things, run the prettier:format and lint scripts in package.json (added in #193).

That way, one gets a chance to fix these before blindly making a PR. We should also update the PR template to let everyone know while making a PR.

Tasks:

alvyynm commented 1 month ago

@sonylomo, @bridgitkanini, @Ase020, @JimmyTron what do you guys think?

sonylomo commented 1 month ago

As long as you're the one fixing it 😃

alvyynm commented 1 month ago

Yes, I'll work on it.