SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.96k stars 98 forks source link

Properly handle adding third-party accounts to Discord #293

Open MenacingPerson opened 2 years ago

MenacingPerson commented 2 years ago

Aknowledgements

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

21.1.0

Application version

v3.8.8

Bug description

For example, when connecting github account, it opens https://discord.com/connections/github?loading=true in firefox.

Additional context

No response

SpacingBat3 commented 2 years ago

It makes sense WebCord will do that, there's almost no exceptions for opening the external links outside of WebCord.

There's also no logic for adding account, it's something I've never done from WebCord.

Also since #294 describe basically the same bug (it's not expected sites such like this to properly work outside of WebCord), but it's focused on further consequences of this bug, I'll just close it in favour of this issue ticket.