SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.96k stars 98 forks source link

Default Browser Selection #338

Closed Spamakin closed 1 year ago

Spamakin commented 1 year ago

There doesn't seem to be any logic as to what browser WebCord uses when I take a link outside of WebCord. Sometimes it is FireFox and sometimes it is Chrome. Could there be a way to select a default browser for this?

eclairevoyant commented 1 year ago

why would that be controlled by webcord? isn't that more related to your pc's default apps settings?

donCESAR12345 commented 1 year ago

if using linux you could try Junction, its purpose is to let you choose between installed browsers

SpacingBat3 commented 1 year ago

why would that be controlled by webcord? isn't that more related to your pc's default apps settings?

Yeah, Electron API is responsible for picking the default browser and it should utilize OS configuration around that (on Linux, this acts like xdg-open). It makes no sense for WebCord to fix that and there's very little I can do about it even if I wanted. See shell.openExternal for API reference.

I'm closing this issue, it makes no sense IMO for WebCord to set something OS is supposed to control. In most apps you are unable to set the default browser, do you? Neither should WebCord be an exception to that.