SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.89k stars 94 forks source link

Fullscreen is not fullscreen #341

Closed ari-party closed 1 year ago

ari-party commented 1 year ago

Aknowledgements

Operating System / Platform

🪟️ Windows

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

v22

Application version

v4

Bug description

Currently for me, Fullscreen does windowed fullscreen, not fullscreen fullscreen. fullscreen fullscreen would not have a title bar. image

Additional context

No response

SpacingBat3 commented 1 year ago

Is your taskbar set to automatically hide?

Sounds like an issue https://github.com/electron/electron/issues/36638, could you confirm if that actually happens?

ari-party commented 1 year ago

Is your taskbar set to automatically hide?

Sounds like an issue https://github.com/electron/electron/issues/36638, could you confirm if that actually happens?

Going to look in a minute!

ari-party commented 1 year ago

Sounds like an issue electron/electron#36638, could you confirm if that actually happens?

What do I look for?

ari-party commented 1 year ago

https://user-images.githubusercontent.com/49074962/207696627-c12f7c53-123b-47d8-b2f0-03cdc7670d70.mp4

SpacingBat3 commented 1 year ago

Sounds like an issue electron/electron#36638, could you confirm if that actually happens?

What do I look for?

I mean, this issue basically describes that fullscreen might be broken if taskbar on Windows is set to be automatically hidden.

You might also want to check if the issue is in v3 latest release. v3 uses Electron 21, which is a bit more mature than 22 and is likely to contain less bugs.

ari-party commented 1 year ago

image

ari-party commented 1 year ago

Want me to downgrade?

SpacingBat3 commented 1 year ago

Want me to downgrade?

I mean, v3 is basically released for people who seem to get some issues with the latest Electron.

Althrough it may not help you if the bug is present in older Electron versions… (I'm pretty sure that's an upstream bug)