Fix broken ⌘A shortcut (Select All) on macOS

SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.

MIT License

1.89k stars 94 forks source link

Fix broken ⌘A shortcut (Select All) on macOS #373

Closed mmorella-dev closed 1 year ago

mmorella-dev commented 1 year ago

This adds the Select All button to the Edit menu.

Electron's menu API requires "Select All" to be present in the Edit menu, in order for the ⌘A shortcut to function
This fixes issue #319

mmorella-dev commented 1 year ago

Screen capture showing the regression, and fix. Tested on macOS Ventura 13.2.

https://user-images.githubusercontent.com/4561733/216158441-b886ba9f-8725-496a-b576-fa1308160700.mov

SpacingBat3 commented 1 year ago

Nice find! Unfortunately, I don't plan merging any PRs for now, as basically v4 is being deprecated for now, until release of v5 WebCord might be a bit dead in terms of the development.