SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.88k stars 94 forks source link

Screenshare Audio #418

Closed Soliprem closed 1 year ago

Soliprem commented 1 year ago

Simply, most discord clients, don't currently offer audio when screensharing

However, this repo right here, inspired from this repo right here implemented a really clever and (I hope) not too complex solution. I have absolutely 0 cpp skills; I'm just a terminal-dweller who does some scripting, so I couldn't make heads or tails of it, but I would assume that someone with some knowledge of these clients would find it a lot easier to make it work.

I am aware of methods to redirect sound into the user's microphone, but this is just strictly superior, as it works even when the user is muted, and does so through a clean API call rather than a hacky piping system.

If it is indeed not complex, I would love to be of assistance in testing. I'm just afraid my cpp is too terrible to write anything worth it.

Personally I think that screenshare sound would make this the go-to for any linux user (certainly for me) as it would just be an open source, feature complete project, so I think this has a lot of value to offer as an idea

SpacingBat3 commented 1 year ago

Duplicate of #154, somewhat possible in WebCord (see --help in command-line – also expect it won't work as it should be) and implemented by #346. Closing this and locking conversation (please continue in already-opened issue ticket).