SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.83k stars 94 forks source link

Option to disable update check #493

Closed pezz closed 7 months ago

pezz commented 7 months ago

Description

Sometimes it can take nearly a week for Flathub to update with latest version of Webcord.

I'd like to be able to disable the built-in update check because I use the Flatpak version and I really have no option to update to a version that isn't available yet.

Cheers.

Suggestions

Allow the check to be optionally disabled.

Alternatives

No response

Additional Context

No response

SpacingBat3 commented 7 months ago

There's already a way to suppress the notifications - you need to "close" them, but not "click" them (on XFCE4 this is made by clicking on the notification but not on the button within it). Moreover, Flathub maintainers could disable update notifications if they provide a custom buildConfig.json (e.g. AUR packages does it, so there's no notification there), as those are clearly intended for official builds that aren't really auto-updated yet.

"Closing" a notification allows you to inform WebCord that you've understood there was an update (since you've made an interaction with it), so it will remain silent for around a week. Then, it just kindly reminds you that there's still an update available if you just have forgot about it.

Either way, I'm closing this. I don't want to entirely disable update notifications, since in the past people were using extremely outdated WebCord builds without any idea there was an update made to it.

pezz commented 7 months ago

What you've described is not how it works on KDE with the Flatpak version (for example and my use case).

Unless you completely disable notifications you get an update warning every time you start Webcord.

Thanks for answering at least, but it's annoying and given your rationale (i.e. "I don't want to because some people never update") I don't see why you can't give people like me an option to disable the check.

pezz commented 7 months ago

P.S. I read what you said more carefully, apologies.

I'll try the Flathub maintainers I guess (you wouldn't happen to have a link, would you?).

SpacingBat3 commented 7 months ago

What you've described is not how it works on KDE with the Flatpak version (for example and my use case).

Because Linux is not standardized enough, and each distro displays notifications in a bit different way.

However whatever triggers the close event in your case, should be a way of doing this. In case of XFCE4 it is just clicking at the notification to make it vanish faster.

Thanks for answering at least, but it's annoying and given your rationale (i.e. "I don't want to because some people never update") I don't see why you can't give people like me an option to disable the check.

It's not just I want to forcibly deny people the right not to update my app, but that people usually choose the easiest way of skipping their duties. Since WebCord requires a manual iteration to update and not updating the Electron could also have it's own negative consequences (e.g. security ones), disabling the notifications entirely could add more burden since people would be just toggling it off for forever, without realizing there was an important update done. So the current implementation enforces some kind of awareness, at least for those using the official builds (as said before, the one can build WebCord with notifications disabled, this is already documented in docs/).

tdworz commented 4 months ago

Such an unfortunate decision.

The right way to handle this (and as is done by most projects -- I know because I use tons of Flatpaks and this is the only one that annoys me in this way), is to have an option to show updates that is enabled by default, but that can be disabled by a user who takes the time to dig through his or her settings.

Of course, you can provide a build option, but it should be an option, like a flag, not a custom build. It shouldn't be the responsibility of every. single. packager. to write custom code to modify upstream; not everyone is Debian.

Even if a packager disables the notification, it should be possible to turn it back on. You shouldn't assume someone doesn't want to know there is an update even if that update should logically come from a packager; sometimes people want to know and there could be many reasons and that's okay.

But to force people to be annoyed with these shocking notifications every single day because of some almost conceived moral standpoint of "skipping their duties" is really extreme in my opinion. My duty is to update using flatpak update and I run that every morning, thank you very much. I don't need this alarming popup in my life.

Please reconsider your views. Thanks for your consideration.

tdworz commented 4 months ago

Also, the Flatpak is not maintained at this time.

https://github.com/SpacingBat3/WebCord/issues/116

SpacingBat3 commented 4 months ago

Of course, you can provide a build option, but it should be an option, like a flag, not a custom build. It shouldn't be the responsibility of every. single. packager. to write custom code to modify upstream; not everyone is Debian.

This is already a thing, so what's the point of that comment? The one shouldn't be ignorant to dev docs before posting such complains.