SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.97k stars 99 forks source link

Noise suppression not working #499

Open a0193143 opened 11 months ago

a0193143 commented 11 months ago

Acknowledgements

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

28.0.0

Application version

4.6.0

Bug description

Both Krisp and Standard mode of noise suprression not working, but official Discord app is fine. Noticed this also not work in both Chromium and Firefox.

Additional context

OS: EndeavourOS with XWayland and Wayland tried. Hardware: Surface Go 3 (using built-in Mic)

As screenshot shows, the volume bar (noise at the moment) in official app (left) is almost 0 compared to Webcord (right). Screenshot_20231218_182308

SpacingBat3 commented 11 months ago

Noticed this also not work in both Chromium and Firefox.

Pretty much self-explainatory why.

SpacingBat3 commented 11 months ago

Also flagging this as Wayland-specific issue for now, since I have no idea if it is a quirk with Wayland or not (possibly not, but as long as nobody reports this on X11, I'll keep issues flagged like that).

a0193143 commented 11 months ago

This isn't Wayland related issue, I could reproduce on Windows as well. Maybe Discord use specific API for noise suppression?

ZenitH-AT commented 11 months ago

Happens with me on X11, too. I've never experienced noise suppression working on any platform. Never worked on web version of discord so there's that.

I get around it by applying noise suppression via Pipewire.

SpacingBat3 commented 11 months ago

Maybe Discord use specific API for noise suppression?

That is very likely to happen, in fact I suspect they're using their own (native) Node module for handling the audio. Take a note it is proprietary for now and WebCord for audio management relies only on Chromium logic (which is why bugs and limitations that occur in Chromium but not in Discord can happen with WebCord as well).