MainPicker Screenshare on Linux Pops Up Three Times Before Sharing Screen

TZProgrammer commented 6 months ago

Acknowledgements

[X] I have checked that there is no other issue describing the same or similar problem that I currently have, regardless if it has been closed or open.
[ ] This bug affects Discord website.
[ ] This issue is confirmed to be reproducible when WebCord is packaged on at least all three latest supported Electron major releases.
[ ] This issue is reproducible in Chrome, Chromium or any Chromium-based browser, e.g Brave or Edge (please write in Additional Context which browser you have used if it is neither Chrome nor unmodified Chromium).
[X] There are no fixes done to master which resolves this issue.
[ ] My issue describes one of the unstable and/or not fully implemented features.
[ ] I have found a workaround to mitigate or temporarily fix this issue in affected releases (please write it in Additional context section below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

28.1.1

Application version

v4.6.1

Bug description

When clicking to share a display / window / region on file picker, the pop up appears again, up to an additional two times (three times total). The screen that is shared is the last one selected on the pop-up.

Additional context

For additional context, this I am running on Wayland.

SpookySkeletons commented 6 months ago

Electron 27 suffers this bug downgrade to 25 and it should stop

SpacingBat3 commented 5 months ago

Maybe new way of handling getDisplayMedia API helps a bit there that was recently pushed to master?

I honestly have no clue how it works right now with Wayland, from my tests it might behave as it was in regular Chromium browser, so there might be no support for Linux for audio sharing at all. Again, if this behaves like in Chromium there's a better change that it will work fine with the audio sharing once that reach stable Chromium builds and Electron, since I dunno whenever the old method (i.e. via getUserMedia()) is going to be deprecated (or has already been) or not and if Electron devs will backport it in some way.

SpacingBat3 commented 5 months ago

Maybe new way of handling getDisplayMedia API helps a bit there that was recently pushed to master?

Since this is now in v4.7.0 and I've tested it on my local repo build with Wayland, I can tell this doesn't happen for me on GNOME under Wayland. Yet again, screen sharing doesn't work for me at all with my current drivers (which is nouveau with GSP.bin loaded) and after choosing the window or screen as a screen share source, gnome-shell crashes for me which is indicated in dmesg by nouveau. On X11 with my current drivers, it works all just fine so I might as well stay on X until things will get more stable on Wayland (my experience with Wayland still sometimes feels like it is in beta, especially in DE's that has been recently made or ported to Wayland).

niko-roether commented 5 months ago

If this helps, I'm experiencing this issue running WebCord v4.7.1 on Arch Linux with Hyprland and xdg-desktop-portal-hyprland. It affects the discord web app as well.

medv commented 4 months ago

If this helps, I'm experiencing this issue running WebCord v4.7.1 on Arch Linux with Hyprland and xdg-desktop-portal-hyprland. It affects the discord web app as well.

Same situation on nixos with hyprland.

SpacingBat3 / WebCord