SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.92k stars 95 forks source link

"Automatic Gain Control" does not work #510

Closed qulxizer closed 8 months ago

qulxizer commented 8 months ago

Acknowledgements

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

v28.1.5

Application version

v4.6.1

Bug description

The automatic gain control feature cannot be disabled and i could not find any workarounds! the issue is a little bit annoying because it control my microphone volume in anytime, i captured a recording while producing the bug.

to reproduce the bug you could make loud noise in your microphone and see the volume get changed in, pavucontrol.

https://github.com/SpacingBat3/WebCord/assets/91550820/64248530-953a-4a84-a036-503acd47c1a1

Additional context

SpacingBat3 commented 8 months ago

I'm pretty sure this is a duplicate of another issue, and this was resolved back then with a comment describing that you can configure this in Discord settings (so again, this is not a WebCord issue).

qulxizer commented 8 months ago

you are right there is you can configure it in discord settings but there issue still there after turning the feature off.

qulxizer commented 8 months ago

if you can take a look into the video i sent, i disabled it from the settings and it doesn't work either, i just tried it in the latest discord release in the aur and it works fine there.

SpacingBat3 commented 8 months ago

I've tested this with:

const old = navigator.mediaDevices.getUserMedia;
navigator.mediaDevices.getUserMedia = (...args) => { console.dir(args); return old(...args); }

Looks like this only happens in Discord settings, with normal use Discord respects this setting. And yes, this is Discord bug and has nothing to do with WebCord, if you want the settings to also respect the user-defined automatic gain control, you should report this to Discord to have this fixed at upstream.