search

SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.83k stars 94 forks source link

Added small doc about environment variable to force Wayland #517

Closed Leonss23 closed 5 months ago

Leonss23 commented 5 months ago

Not sure it belongs to Flags.md though.

Info: Electron environment variables

SpacingBat3 commented 5 months ago

I don't think I should be the one who's documenting the Electron's env vars, Electron docs exist for that. Do you really think each Electron-based project should copy-paste it from their docs? Then again, there's way more flags and env vars in Electron that could be documented the similar way, and it would be all outdated just with the Electron update.

Also, I go for the reasons that using native Wayland with Chromium is still something that still isn't ready yet since it isn't something that's been default for the upstream and therefore it's up to power users to opt-in for it if they want to. I don't want to document this, eventually I might make it a bit easier for Wayland users to have some features enabled in the code to make a switch much easier (e.g. you don't have to enable PipeWire screen sharing feature on your own, WebCord is capable of determining if it's running in Wayland/XWayland enviroment and be capable enabling this on its own).

For both of these reasons, I don't really like the idea of merging this PR at all. I'll close this, but you are still free to share your thoughts there.

Leonss23 commented 5 months ago

np