Screenshare Window Freezes

Tahinli commented 1 week ago

Acknowledgements

[X] I have checked that there is no other issue describing the same or similar problem that I currently have, regardless if it has been closed or open.
[ ] This bug affects Discord website.
[ ] This issue is confirmed to be reproducible when WebCord is packaged on at least all three latest supported Electron major releases.
[ ] This issue is reproducible in Chrome, Chromium or any Chromium-based browser, e.g Brave or Edge (please write in Additional Context which browser you have used if it is neither Chrome nor unmodified Chromium).
[ ] There are no fixes done to master which resolves this issue.
[ ] My issue describes one of the unstable and/or not fully implemented features.
[ ] I have found a workaround to mitigate or temporarily fix this issue in affected releases (please write it in Additional context section below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

31.1.0

Application version

4.10.0

Bug description

When I want to share screen, stuck in screen share screen .

Additional context

This window freezes in this state visually. Exit button or starting stream don't let me escape from there.

Inky1003 commented 6 days ago

Fixed? Which commit?

SpacingBat3 commented 6 days ago

Fixed? Which commit?

@Inky1003 GitHub kinda describes/renders it like so (the closest representation in MD):

<a href=/SpacingBat3 title="SpacingBat3 • he/him

Student and intermediate self-taught TypeScript / Node.js developer, with little experience with C/C++/ASM (GAT x86)."> SpacingBat3 closed this as completed in https://github.com/SpacingBat3/WebCord/commit/d4d4c874039bd9f0e63178db6d9a7cb6c53ef537 (...)

I don't need to manually mention commits if it is in git history. The question itself is kinda stupid tbh, the answer is literally above your comment 😄 (or at least, that's how it renders normally on GitHub website; even OctoDroid that is unofficial and open-source client for GitHub on Android seems to support it so IDK why you haven't noticed this)…

Inky1003 commented 5 days ago

Yeah, I haven't noticed the pull request there.

Tahinli commented 5 days ago

Fixed? Which commit?

@Inky1003 GitHub kinda describes/renders it like so (the closest representation in MD):

SpacingBat3 closed this as completed in d4d4c87 (...)

I don't need to manually mention commits if it is in git history. The question itself is kinda stupid tbh, the answer is literally above your comment 😄 (or at least, that's how it renders normally on GitHub website; even OctoDroid that is unofficial and open-source client for GitHub on Android seems to support it so IDK why you haven't noticed this)…

Be polite, my friend. Humans are capable of doing mistakes.

Inky1003 commented 5 days ago

Be polite, my friend. Humans are capable of doing mistakes.

Thanks. Patience is gold, and It's sadly rare. Also, he wasted more energy to laugh at my silly face than to reply with a short and polite "See d4d4c87" or even to say the exact same thing without laughing at me. Anyways, things should go on, so let's continue.

@SpacingBat3 which next release will have this commit applied? AUR helpers updates the "bin" package but I forget the newest release is broken. Also, I only use WebCord for screensharing, It's the best app currently for that.

SpacingBat3 commented 5 days ago

Yeah, I haven't noticed the pull request there.

This made me realise I haven't noticed myself what's directly above 😅 (just in case this PR is actually someone else's bot doing auto PR from my repo to their fork). Guess my work on markdown representation didn't help to locate the right message at all…

(…) Also, he wasted more energy to laugh at my silly face than to reply with a short and polite "See d4d4c87" or even to say the exact same thing without laughing at me. (…)

Didn't really laught at you (it's not that kind of emoji I used), more or less I wanted just to mention what happens normally on GitHub in case you wasn't aware of it (this linking mechanism is cool way to automatically close issues while commiting, not only this saves time on going to GitHub and taking care of manually for those things, but actually is well represented in the issue tracker). I guess I want more to educate people how things work (or make them realise it) than copy-paste the exact same message every time I see this question. I've also had some guesses you might be using unofficial client (these tend to be incomplete in features, so that's why some part of my messages provokes the reply for it):

(…) so IDK why you haven't noticed this (…)

For the future, I don't see a bug tracker to be right place to discuss such manner. More than questions with reapetetive answer (I guess that's my vision of stupid questions, at least for some places) I hate things going out-of-the-topic and whole conversation starting to be a frontline (really, sometimes one mistake or misinterpretation like the use of he/she than they can make internet start fight with each other). So let's just stop there, I guess I'll further hide this whole conversation giving its character…

SpacingBat3 commented 5 days ago

@SpacingBat3 which next release will have this commit applied? AUR helpers updates the "bin" package but I forget the newest release is broken.

Well, the release cycle is more or less continuous and SemVer-inspired, given this is considered as patch it should reach 4.10.1 or so…

Also, I only use WebCord for screensharing, It's the best app currently for that.

I don't think this is the feature WebCord best shines in it… I mean, sure it works way better than the past implementations of it (it's now using modern Electron APIs, avoiding double IPC communication between Discord, WebCord and ~BrowserView~ WebContentsView + I don't inject anything as HTML into the webpage, CSS injection in WebCord avoids doing that as well), but it is still highly dependant on Chromium's implementation of it. I think Discord's use of native modules might surpass WebCord's capabilities of screen sharing, although WebCord's way is probably more portable and open-source, given the Chromium being ported to more platforms than just what Electron supports + WebCord code actually helping with it by treating everything unixly if it isn't macOS or Windows…

SpacingBat3 / WebCord