An "external link" prompt appears on every link click

AlexFolland commented 1 month ago

Acknowledgements

[X] I have checked that there is no other issue describing the same or similar problem that I currently have, regardless if it has been closed or open.
[ ] This bug affects Discord website.
[X] This issue is confirmed to be reproducible when WebCord is packaged on at least all three latest supported Electron major releases.
[ ] This issue is reproducible in Chrome, Chromium or any Chromium-based browser, e.g Brave or Edge (please write in Additional Context which browser you have used if it is neither Chrome nor unmodified Chromium).
[X] There are no fixes done to master which resolves this issue.
[ ] My issue describes one of the unstable and/or not fully implemented features.
[ ] I have found a workaround to mitigate or temporarily fix this issue in affected releases (please write it in Additional context section below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

31.3.1

Application version

4.10.0

Bug description

The following prompt prevents immediately opening a link every time a link is clicked, unlike the official Discord app.

My expected behavior for such prompts is to show it either 1 or 0 times total before saving a state that does not cause the prompt to appear, and/or present an option in the prompt to never show it again, like an "Always yes" button, which then adds it to the list of shown prompts which can be reset in a settings menu.

Additional context

No response

SpacingBat3 commented 1 month ago

This is not a bug, it is implemented as it should be. This is an additional protection layer, in case Discord ones aren't enough (e.g. if one of their deps is bypassing it) or Discord itself is opening suspicious links. If you not wish to have it, the one is free to disable it in the WebCord settings, but this may lower the app security in that aspect (since those popups are handled on the browser level, it's way harder to bypass them). The prompt also allows you to copy links, since sometimes native and Discord's popups collide and Discord may disable displaying the default popups in some places.

AlexFolland commented 1 month ago

the one is free to disable it in the WebCord settings

After checking through the settings a couple times, I haven't seen the option for it there. What is the setting's label? I might be missing it.

AlexFolland commented 1 month ago

Oh, I see it here.

The setting is "Always warn user about cross-origin redirections to external applications.". I'm closing this. Thank you for the explanation.

SpacingBat3 / WebCord